extensions/browser/api/web_request/web_request_time_tracker.cc - Issue 664933004: Standardize usage of virtual/override/final in extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/web_request/web_request_time_tracker.cc

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/web_request/web_request_api.cc ('k') | extensions/browser/api/web_view/web_view_internal_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/web_request/web_request_time_tracker.cc

diff --git a/extensions/browser/api/web_request/web_request_time_tracker.cc b/extensions/browser/api/web_request/web_request_time_tracker.cc

index da638b948a3096c8e1ab03173e9eb8e3cbec223b..3449e90757e2457ccf4af8c14652d7c8f58825c8 100644

--- a/extensions/browser/api/web_request/web_request_time_tracker.cc

+++ b/extensions/browser/api/web_request/web_request_time_tracker.cc

@@ -34,15 +34,15 @@ const size_t kNumExcessiveDelaysBeforeWarning = 10u;

// that sets a warning in the extension service of |profile|.

class DefaultDelegate : public ExtensionWebRequestTimeTrackerDelegate {

public:

- virtual ~DefaultDelegate() {}

+ ~DefaultDelegate() override {}

// Implementation of ExtensionWebRequestTimeTrackerDelegate.

- virtual void NotifyExcessiveDelays(

+ void NotifyExcessiveDelays(

void* profile,

size_t num_delayed_messages,

size_t total_num_messages,

const std::set<std::string>& extension_ids) override;

- virtual void NotifyModerateDelays(

+ void NotifyModerateDelays(

void* profile,

size_t num_delayed_messages,

size_t total_num_messages,

« no previous file with comments | « extensions/browser/api/web_request/web_request_api.cc ('k') | extensions/browser/api/web_view/web_view_internal_api.h » ('j') | no next file with comments »