extensions/common/manifest_handlers/requirements_info.h - Issue 664933004: Standardize usage of virtual/override/final in extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/manifest_handlers/requirements_info.h

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/common/manifest_handlers/permissions_parser.cc ('k') | extensions/common/manifest_handlers/sandboxed_page_info.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/manifest_handlers/requirements_info.h

diff --git a/extensions/common/manifest_handlers/requirements_info.h b/extensions/common/manifest_handlers/requirements_info.h

index 18d4df069c07f298a979a5a8a3d0b8f394bf18b0..ebcb39f3cb296034c651dbad484f45cedb092f34 100644

--- a/extensions/common/manifest_handlers/requirements_info.h

+++ b/extensions/common/manifest_handlers/requirements_info.h

@@ -17,7 +17,7 @@ namespace extensions {

// Declared requirements for the extension.

struct RequirementsInfo : public Extension::ManifestData {

explicit RequirementsInfo(const Manifest* manifest);

- virtual ~RequirementsInfo();

+ ~RequirementsInfo() override;

bool webgl;

bool npapi;

@@ -30,16 +30,16 @@ struct RequirementsInfo : public Extension::ManifestData {

class RequirementsHandler : public ManifestHandler {

public:

RequirementsHandler();

- virtual ~RequirementsHandler();

+ ~RequirementsHandler() override;

- virtual bool Parse(Extension* extension, base::string16* error) override;

+ bool Parse(Extension* extension, base::string16* error) override;

- virtual bool AlwaysParseForType(Manifest::Type type) const override;

+ bool AlwaysParseForType(Manifest::Type type) const override;

- virtual const std::vector<std::string> PrerequisiteKeys() const override;

+ const std::vector<std::string> PrerequisiteKeys() const override;

private:

- virtual const std::vector<std::string> Keys() const override;

+ const std::vector<std::string> Keys() const override;

DISALLOW_COPY_AND_ASSIGN(RequirementsHandler);

};