Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: extensions/renderer/guest_view/guest_view_container.h

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/guest_view/guest_view_container.h
diff --git a/extensions/renderer/guest_view/guest_view_container.h b/extensions/renderer/guest_view/guest_view_container.h
index b526bb62d25f500258dc61a3c29baa4179442d01..d891775c94c90f162512625eac67485d46e56f16 100644
--- a/extensions/renderer/guest_view/guest_view_container.h
+++ b/extensions/renderer/guest_view/guest_view_container.h
@@ -56,7 +56,7 @@ class GuestViewContainer : public content::BrowserPluginDelegate,
GuestViewContainer(content::RenderFrame* render_frame,
const std::string& mime_type);
- virtual ~GuestViewContainer();
+ ~GuestViewContainer() override;
static GuestViewContainer* FromID(int render_view_routing_id,
int element_instance_id);
@@ -64,14 +64,14 @@ class GuestViewContainer : public content::BrowserPluginDelegate,
void AttachGuest(linked_ptr<AttachRequest> request);
// BrowserPluginDelegate implementation.
- virtual void SetElementInstanceID(int element_instance_id) override;
- virtual void DidFinishLoading() override;
- virtual void DidReceiveData(const char* data, int data_length) override;
- virtual void Ready() override;
+ void SetElementInstanceID(int element_instance_id) override;
+ void DidFinishLoading() override;
+ void DidReceiveData(const char* data, int data_length) override;
+ void Ready() override;
// RenderFrameObserver override.
- virtual void OnDestruct() override;
- virtual bool OnMessageReceived(const IPC::Message& message) override;
+ void OnDestruct() override;
+ bool OnMessageReceived(const IPC::Message& message) override;
private:
void OnCreateMimeHandlerViewGuestACK(int element_instance_id);
« no previous file with comments | « extensions/renderer/extensions_render_frame_observer.h ('k') | extensions/renderer/logging_native_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698