extensions/browser/api/web_request/web_request_api.cc - Issue 664933004: Standardize usage of virtual/override/final in extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/web_request/web_request_api.cc

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/web_request/web_request_api.h ('k') | extensions/browser/api/web_request/web_request_time_tracker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/web_request/web_request_api.cc

diff --git a/extensions/browser/api/web_request/web_request_api.cc b/extensions/browser/api/web_request/web_request_api.cc

index 01579704dc26ccfb84763657622bd71a6a00ddab..a188447e4f60be779268176a24cb3e9efb415744 100644

--- a/extensions/browser/api/web_request/web_request_api.cc

+++ b/extensions/browser/api/web_request/web_request_api.cc

@@ -2130,9 +2130,8 @@ class ClearCacheQuotaHeuristic : public extensions::QuotaLimitHeuristic {

"MAX_HANDLER_BEHAVIOR_CHANGED_CALLS_PER_10_MINUTES"),

callback_registered_(false),

weak_ptr_factory_(this) {}

- virtual ~ClearCacheQuotaHeuristic() {}

- virtual bool Apply(Bucket* bucket,

- const base::TimeTicks& event_time) override;

+ ~ClearCacheQuotaHeuristic() override {}

+ bool Apply(Bucket* bucket, const base::TimeTicks& event_time) override;

private:

// Callback that is triggered by the ExtensionWebRequestEventRouter on a page