extensions/browser/file_highlighter.h - Issue 664933004: Standardize usage of virtual/override/final in extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/file_highlighter.h

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/extension_web_contents_observer.h ('k') | extensions/browser/guest_view/app_view/app_view_guest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/file_highlighter.h

diff --git a/extensions/browser/file_highlighter.h b/extensions/browser/file_highlighter.h

index c628488d61dc0008ea716929ed5b74de7f748dec..d172d315ebceefdb951a1d339d4bcd6d21a34cff 100644

--- a/extensions/browser/file_highlighter.h

+++ b/extensions/browser/file_highlighter.h

@@ -73,7 +73,7 @@ class ManifestHighlighter : public FileHighlighter {

ManifestHighlighter(const std::string& manifest,

const std::string& key,

const std::string& specific /* optional */);

- virtual ~ManifestHighlighter();

+ ~ManifestHighlighter() override;

private:

// Called from the constructor; determine the start and end bounds of a

@@ -97,7 +97,7 @@ class ManifestHighlighter : public FileHighlighter {

class SourceHighlighter : public FileHighlighter {

public:

SourceHighlighter(const std::string& source, size_t line_number);

- virtual ~SourceHighlighter();

+ ~SourceHighlighter() override;

private:

// Called from the constructor; determine the bounds of the line in the source

« no previous file with comments | « extensions/browser/extension_web_contents_observer.h ('k') | extensions/browser/guest_view/app_view/app_view_guest.h » ('j') | no next file with comments »