Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_api.h

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_api.h
diff --git a/extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_api.h b/extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_api.h
index 56c165db3449a7c4366056854b4a53d94bfa5397..3b0e4e08b661af82b9fffd2877ea9e31e89c8ce2 100644
--- a/extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_api.h
+++ b/extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_api.h
@@ -25,10 +25,10 @@ class BluetoothLowEnergyAPI : public BrowserContextKeyedAPI {
static BluetoothLowEnergyAPI* Get(content::BrowserContext* context);
explicit BluetoothLowEnergyAPI(content::BrowserContext* context);
- virtual ~BluetoothLowEnergyAPI();
+ ~BluetoothLowEnergyAPI() override;
// KeyedService implementation..
- virtual void Shutdown() override;
+ void Shutdown() override;
BluetoothLowEnergyEventRouter* event_router() const {
return event_router_.get();
@@ -59,10 +59,10 @@ class BluetoothLowEnergyExtensionFunction : public AsyncExtensionFunction {
BluetoothLowEnergyExtensionFunction();
protected:
- virtual ~BluetoothLowEnergyExtensionFunction();
+ ~BluetoothLowEnergyExtensionFunction() override;
// ExtensionFunction override.
- virtual bool RunAsync() override;
+ bool RunAsync() override;
// Implemented by individual bluetoothLowEnergy extension functions to perform
// the body of the function. This invoked asynchonously after RunAsync after
@@ -81,10 +81,10 @@ class BluetoothLowEnergyConnectFunction
BLUETOOTHLOWENERGY_CONNECT);
protected:
- virtual ~BluetoothLowEnergyConnectFunction() {}
+ ~BluetoothLowEnergyConnectFunction() override {}
// BluetoothLowEnergyExtensionFunction override.
- virtual bool DoWork() override;
+ bool DoWork() override;
private:
// Success and error callbacks, called by
@@ -100,10 +100,10 @@ class BluetoothLowEnergyDisconnectFunction
BLUETOOTHLOWENERGY_DISCONNECT);
protected:
- virtual ~BluetoothLowEnergyDisconnectFunction() {}
+ ~BluetoothLowEnergyDisconnectFunction() override {}
// BluetoothLowEnergyExtensionFunction override.
- virtual bool DoWork() override;
+ bool DoWork() override;
private:
// Success and error callbacks, called by
@@ -119,10 +119,10 @@ class BluetoothLowEnergyGetServiceFunction
BLUETOOTHLOWENERGY_GETSERVICE);
protected:
- virtual ~BluetoothLowEnergyGetServiceFunction() {}
+ ~BluetoothLowEnergyGetServiceFunction() override {}
// BluetoothLowEnergyExtensionFunction override.
- virtual bool DoWork() override;
+ bool DoWork() override;
};
class BluetoothLowEnergyGetServicesFunction
@@ -132,10 +132,10 @@ class BluetoothLowEnergyGetServicesFunction
BLUETOOTHLOWENERGY_GETSERVICES);
protected:
- virtual ~BluetoothLowEnergyGetServicesFunction() {}
+ ~BluetoothLowEnergyGetServicesFunction() override {}
// BluetoothLowEnergyExtensionFunction override.
- virtual bool DoWork() override;
+ bool DoWork() override;
};
class BluetoothLowEnergyGetCharacteristicFunction
@@ -145,10 +145,10 @@ class BluetoothLowEnergyGetCharacteristicFunction
BLUETOOTHLOWENERGY_GETCHARACTERISTIC);
protected:
- virtual ~BluetoothLowEnergyGetCharacteristicFunction() {}
+ ~BluetoothLowEnergyGetCharacteristicFunction() override {}
// BluetoothLowEnergyExtensionFunction override.
- virtual bool DoWork() override;
+ bool DoWork() override;
};
class BluetoothLowEnergyGetCharacteristicsFunction
@@ -158,10 +158,10 @@ class BluetoothLowEnergyGetCharacteristicsFunction
BLUETOOTHLOWENERGY_GETCHARACTERISTICS);
protected:
- virtual ~BluetoothLowEnergyGetCharacteristicsFunction() {}
+ ~BluetoothLowEnergyGetCharacteristicsFunction() override {}
// BluetoothLowEnergyExtensionFunction override.
- virtual bool DoWork() override;
+ bool DoWork() override;
};
class BluetoothLowEnergyGetIncludedServicesFunction
@@ -171,10 +171,10 @@ class BluetoothLowEnergyGetIncludedServicesFunction
BLUETOOTHLOWENERGY_GETINCLUDEDSERVICES);
protected:
- virtual ~BluetoothLowEnergyGetIncludedServicesFunction() {}
+ ~BluetoothLowEnergyGetIncludedServicesFunction() override {}
// BluetoothLowEnergyExtensionFunction override.
- virtual bool DoWork() override;
+ bool DoWork() override;
};
class BluetoothLowEnergyGetDescriptorFunction
@@ -184,10 +184,10 @@ class BluetoothLowEnergyGetDescriptorFunction
BLUETOOTHLOWENERGY_GETDESCRIPTOR);
protected:
- virtual ~BluetoothLowEnergyGetDescriptorFunction() {}
+ ~BluetoothLowEnergyGetDescriptorFunction() override {}
// BluetoothLowEnergyExtensionFunction override.
- virtual bool DoWork() override;
+ bool DoWork() override;
};
class BluetoothLowEnergyGetDescriptorsFunction
@@ -197,10 +197,10 @@ class BluetoothLowEnergyGetDescriptorsFunction
BLUETOOTHLOWENERGY_GETDESCRIPTORS);
protected:
- virtual ~BluetoothLowEnergyGetDescriptorsFunction() {}
+ ~BluetoothLowEnergyGetDescriptorsFunction() override {}
// BluetoothLowEnergyExtensionFunction override.
- virtual bool DoWork() override;
+ bool DoWork() override;
};
class BluetoothLowEnergyReadCharacteristicValueFunction
@@ -210,10 +210,10 @@ class BluetoothLowEnergyReadCharacteristicValueFunction
BLUETOOTHLOWENERGY_READCHARACTERISTICVALUE);
protected:
- virtual ~BluetoothLowEnergyReadCharacteristicValueFunction() {}
+ ~BluetoothLowEnergyReadCharacteristicValueFunction() override {}
// BluetoothLowEnergyExtensionFunction override.
- virtual bool DoWork() override;
+ bool DoWork() override;
private:
// Success and error callbacks, called by
@@ -232,10 +232,10 @@ class BluetoothLowEnergyWriteCharacteristicValueFunction
BLUETOOTHLOWENERGY_WRITECHARACTERISTICVALUE);
protected:
- virtual ~BluetoothLowEnergyWriteCharacteristicValueFunction() {}
+ ~BluetoothLowEnergyWriteCharacteristicValueFunction() override {}
// BluetoothLowEnergyExtensionFunction override.
- virtual bool DoWork() override;
+ bool DoWork() override;
private:
// Success and error callbacks, called by
@@ -255,10 +255,10 @@ class BluetoothLowEnergyStartCharacteristicNotificationsFunction
BLUETOOTHLOWENERGY_STARTCHARACTERISTICNOTIFICATIONS);
protected:
- virtual ~BluetoothLowEnergyStartCharacteristicNotificationsFunction() {}
+ ~BluetoothLowEnergyStartCharacteristicNotificationsFunction() override {}
// BluetoothLowEnergyExtensionFunction override.
- virtual bool DoWork() override;
+ bool DoWork() override;
private:
// Success and error callbacks, called by
@@ -275,10 +275,10 @@ class BluetoothLowEnergyStopCharacteristicNotificationsFunction
BLUETOOTHLOWENERGY_STOPCHARACTERISTICNOTIFICATIONS);
protected:
- virtual ~BluetoothLowEnergyStopCharacteristicNotificationsFunction() {}
+ ~BluetoothLowEnergyStopCharacteristicNotificationsFunction() override {}
// BluetoothLowEnergyExtensionFunction override.
- virtual bool DoWork() override;
+ bool DoWork() override;
private:
// Success and error callbacks, called by
@@ -294,10 +294,10 @@ class BluetoothLowEnergyReadDescriptorValueFunction
BLUETOOTHLOWENERGY_READDESCRIPTORVALUE);
protected:
- virtual ~BluetoothLowEnergyReadDescriptorValueFunction() {}
+ ~BluetoothLowEnergyReadDescriptorValueFunction() override {}
// BluetoothLowEnergyExtensionFunction override.
- virtual bool DoWork() override;
+ bool DoWork() override;
private:
// Success and error callbacks, called by
@@ -316,10 +316,10 @@ class BluetoothLowEnergyWriteDescriptorValueFunction
BLUETOOTHLOWENERGY_WRITEDESCRIPTORVALUE);
protected:
- virtual ~BluetoothLowEnergyWriteDescriptorValueFunction() {}
+ ~BluetoothLowEnergyWriteDescriptorValueFunction() override {}
// BluetoothLowEnergyExtensionFunction override.
- virtual bool DoWork() override;
+ bool DoWork() override;
private:
// Success and error callbacks, called by

Powered by Google App Engine
This is Rietveld 408576698