Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: extensions/browser/extension_prefs.h

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/extension_pref_value_map_factory.h ('k') | extensions/browser/extension_prefs.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/extension_prefs.h
diff --git a/extensions/browser/extension_prefs.h b/extensions/browser/extension_prefs.h
index 2a1caac58ac67918c81813ddcfe508e620491603..cdfb278d35963e8b7b0de81dfbc8b20eb1e93d4a 100644
--- a/extensions/browser/extension_prefs.h
+++ b/extensions/browser/extension_prefs.h
@@ -149,7 +149,7 @@ class ExtensionPrefs : public ExtensionScopedPrefs, public KeyedService {
const std::vector<ExtensionPrefsObserver*>& early_observers,
scoped_ptr<TimeProvider> time_provider);
- virtual ~ExtensionPrefs();
+ ~ExtensionPrefs() override;
// Convenience function to get the ExtensionPrefs for a BrowserContext.
static ExtensionPrefs* Get(content::BrowserContext* context);
@@ -218,35 +218,34 @@ class ExtensionPrefs : public ExtensionScopedPrefs, public KeyedService {
void GetExtensions(ExtensionIdList* out);
// ExtensionScopedPrefs methods:
- virtual void UpdateExtensionPref(const std::string& id,
- const std::string& key,
- base::Value* value) override;
+ void UpdateExtensionPref(const std::string& id,
+ const std::string& key,
+ base::Value* value) override;
- virtual void DeleteExtensionPrefs(const std::string& id) override;
+ void DeleteExtensionPrefs(const std::string& id) override;
- virtual bool ReadPrefAsBoolean(const std::string& extension_id,
- const std::string& pref_key,
- bool* out_value) const override;
+ bool ReadPrefAsBoolean(const std::string& extension_id,
+ const std::string& pref_key,
+ bool* out_value) const override;
- virtual bool ReadPrefAsInteger(const std::string& extension_id,
- const std::string& pref_key,
- int* out_value) const override;
+ bool ReadPrefAsInteger(const std::string& extension_id,
+ const std::string& pref_key,
+ int* out_value) const override;
- virtual bool ReadPrefAsString(const std::string& extension_id,
- const std::string& pref_key,
- std::string* out_value) const override;
+ bool ReadPrefAsString(const std::string& extension_id,
+ const std::string& pref_key,
+ std::string* out_value) const override;
- virtual bool ReadPrefAsList(const std::string& extension_id,
- const std::string& pref_key,
- const base::ListValue** out_value) const override;
+ bool ReadPrefAsList(const std::string& extension_id,
+ const std::string& pref_key,
+ const base::ListValue** out_value) const override;
- virtual bool ReadPrefAsDictionary(
+ bool ReadPrefAsDictionary(
const std::string& extension_id,
const std::string& pref_key,
const base::DictionaryValue** out_value) const override;
- virtual bool HasPrefForExtension(const std::string& extension_id) const
- override;
+ bool HasPrefForExtension(const std::string& extension_id) const override;
// Did the extension ask to escalate its permission during an upgrade?
bool DidExtensionEscalatePermissions(const std::string& id);
« no previous file with comments | « extensions/browser/extension_pref_value_map_factory.h ('k') | extensions/browser/extension_prefs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698