extensions/browser/api/storage/storage_frontend.cc - Issue 664933004: Standardize usage of virtual/override/final in extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/storage/storage_frontend.cc

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/storage/storage_frontend.h ('k') | extensions/browser/api/storage/weak_unlimited_settings_storage.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/storage/storage_frontend.cc

diff --git a/extensions/browser/api/storage/storage_frontend.cc b/extensions/browser/api/storage/storage_frontend.cc

index f14b538fd2a4a9f53e92d0b5c26c04c73013fa8e..62a7fd01e124e9bed12532f9cce57fde357452ad 100644

--- a/extensions/browser/api/storage/storage_frontend.cc

+++ b/extensions/browser/api/storage/storage_frontend.cc

@@ -36,10 +36,9 @@ class DefaultObserver : public SettingsObserver {

: browser_context_(context) {}

// SettingsObserver implementation.

- virtual void OnSettingsChanged(

- const std::string& extension_id,

- settings_namespace::Namespace settings_namespace,

- const std::string& change_json) override {

+ void OnSettingsChanged(const std::string& extension_id,

+ settings_namespace::Namespace settings_namespace,

+ const std::string& change_json) override {

// TODO(gdk): This is a temporary hack while the refactoring for

// string-based event payloads is removed. http://crbug.com/136045

scoped_ptr<base::ListValue> args(new base::ListValue());