extensions/browser/content_hash_fetcher.cc - Issue 664933004: Standardize usage of virtual/override/final in extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/content_hash_fetcher.cc

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/content_hash_fetcher.cc

diff --git a/extensions/browser/content_hash_fetcher.cc b/extensions/browser/content_hash_fetcher.cc

index cbf032d2a606726b796ab68a3a82a5ec02f7a875..e4190be3b533cf7e167f090399aa2896055972f4 100644

--- a/extensions/browser/content_hash_fetcher.cc

+++ b/extensions/browser/content_hash_fetcher.cc

@@ -82,7 +82,7 @@ class ContentHashFetcherJob

private:

friend class base::RefCountedThreadSafe<ContentHashFetcherJob>;

- virtual ~ContentHashFetcherJob();

+ ~ContentHashFetcherJob() override;

// Tries to load a verified_contents.json file at |path|. On successfully

// reading and validing the file, the verified_contents_ member variable will

@@ -97,7 +97,7 @@ class ContentHashFetcherJob

void DoneCheckingForVerifiedContents(bool found);

// URLFetcherDelegate interface

- virtual void OnURLFetchComplete(const net::URLFetcher* source) override;

+ void OnURLFetchComplete(const net::URLFetcher* source) override;

// Callback for when we're done ensuring we have verified contents, and are

// ready to move on to MaybeCreateHashes.

« no previous file with comments | « extensions/browser/blob_holder.h ('k') | extensions/browser/content_verifier.h » ('j') | no next file with comments »