extensions/common/permissions/socket_permission.h - Issue 664933004: Standardize usage of virtual/override/final in extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/permissions/socket_permission.h

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/common/permissions/settings_override_permission.h ('k') | extensions/common/permissions/usb_device_permission.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/permissions/socket_permission.h

diff --git a/extensions/common/permissions/socket_permission.h b/extensions/common/permissions/socket_permission.h

index 5077efde301cd75bed209de4bc63a8ba99f4c6d1..e3f77e4119281248a88b2c2ca583026bb65f4667 100644

--- a/extensions/common/permissions/socket_permission.h

+++ b/extensions/common/permissions/socket_permission.h

@@ -26,10 +26,10 @@ class SocketPermission

explicit SocketPermission(const APIPermissionInfo* info);

- virtual ~SocketPermission();

+ ~SocketPermission() override;

// Returns the localized permission messages of this permission.

- virtual PermissionMessages GetMessages() const override;

+ PermissionMessages GetMessages() const override;

private:

bool AddAnyHostMessage(PermissionMessages& messages) const;