extensions/browser/extension_prefs.cc - Issue 664933004: Standardize usage of virtual/override/final in extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/extension_prefs.cc

Issue 664933004: Standardize usage of virtual/override/final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/extension_prefs.cc

diff --git a/extensions/browser/extension_prefs.cc b/extensions/browser/extension_prefs.cc

index 5930b2307f37809dfeecffd1ed03e82ee7048c47..4d476f52a408a5c429f06dbd2ebc0e38aa9ecb10 100644

--- a/extensions/browser/extension_prefs.cc

+++ b/extensions/browser/extension_prefs.cc

@@ -201,11 +201,10 @@ class ScopedExtensionPrefUpdate : public DictionaryPrefUpdate {

DictionaryPrefUpdate(service, pref_names::kExtensions),

extension_id_(extension_id) {}

- virtual ~ScopedExtensionPrefUpdate() {

- }

+ ~ScopedExtensionPrefUpdate() override {}

// DictionaryPrefUpdate overrides:

- virtual base::DictionaryValue* Get() override {

+ base::DictionaryValue* Get() override {

base::DictionaryValue* dict = DictionaryPrefUpdate::Get();

base::DictionaryValue* extension = NULL;

if (!dict->GetDictionary(extension_id_, &extension)) {

« no previous file with comments | « extensions/browser/extension_prefs.h ('k') | extensions/browser/extension_prefs_factory.h » ('j') | no next file with comments »