Rename Node::inShadowIncludingDocument() to Node::isConnected()

Rename Node::inShadowIncludingDocument() to Node::isConnected()

Batch renaming to honer DOM Standard.

BUG=628101
Committed: https://crrev.com/45582d25b93f796b89b4207e6a3af66d734ed952
Cr-Commit-Position: refs/heads/master@{#405691}

[hayato, 2016-07-14 07:47:49]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 07:48:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hayato, 2016-07-14 07:48:53]

Description was changed from

==========
Rename Node::inShadowIncludingDocument() to Node::isConnected() to honer DOM
Standard

BUG=
==========

to

==========
Rename Node::inShadowIncludingDocument() to Node::isConnected()

Batch renaming to honer DOM Standard.

BUG=628101
==========

[hayato, 2016-07-14 07:51:38]

hayato@chromium.org changed reviewers:
+ kochi@chromium.org, tkent@chromium.org

[hayato, 2016-07-14 07:51:39]

PTAL

[kochi, 2016-07-14 08:08:57]

LGTM % one Node.idl nit

https://codereview.chromium.org/2149893003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/Node.idl (right):

https://codereview.chromium.org/2149893003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/Node.idl:45: [ImplementedAs=isConnected,
Measure] readonly attribute boolean isConnected;
ImplementedAs= is no longer necessary (same name).

[tkent, 2016-07-14 08:21:10]

lgtm

https://codereview.chromium.org/2149893003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/Node.h (right):

https://codereview.chromium.org/2149893003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/Node.h:480: // If you are looking for
inDocument() or inShadowIncludingDocument(), they were removed. Use
isConnected() instead.
I don't think this line is necessary.

Also, I want a brief explanation of what is 'connected' here. Even Blink
developers aren't familiar with it yet.

[hayato, 2016-07-14 08:44:37]

addressed

[hayato, 2016-07-14 08:44:39]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 08:45:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hayato, 2016-07-14 08:47:12]

https://codereview.chromium.org/2149893003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/Node.h (right):

https://codereview.chromium.org/2149893003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/Node.h:480: // If you are looking for
inDocument() or inShadowIncludingDocument(), they were removed. Use
isConnected() instead.
Done.

Since the definition of "connected" is "An element is connected if its
shadow-including root is a document.", I have added a link to the definition in
DOM Standard.

https://codereview.chromium.org/2149893003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/Node.idl (right):

https://codereview.chromium.org/2149893003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/Node.idl:45: [ImplementedAs=isConnected,
Measure] readonly attribute boolean isConnected;
Done

[hayato, 2016-07-14 08:47:21]

The CQ bit was unchecked by hayato@chromium.org

[hayato, 2016-07-14 08:47:27]

The CQ bit was checked by hayato@chromium.org

[hayato, 2016-07-14 08:47:28]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
kochi@chromium.org
Link to the patchset: https://codereview.chromium.org/2149893003/#ps20001
(title: "addressed")

[commit-bot: I haz the power, 2016-07-14 08:47:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 11:06:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 11:06:20]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[hayato, 2016-07-15 00:36:27]

The CQ bit was checked by hayato@chromium.org

[commit-bot: I haz the power, 2016-07-15 00:36:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 03:54:55]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-15 03:57:31]

Description was changed from

==========
Rename Node::inShadowIncludingDocument() to Node::isConnected()

Batch renaming to honer DOM Standard.

BUG=628101
==========

to

==========
Rename Node::inShadowIncludingDocument() to Node::isConnected()

Batch renaming to honer DOM Standard.

BUG=628101

Committed: https://crrev.com/45582d25b93f796b89b4207e6a3af66d734ed952
Cr-Commit-Position: refs/heads/master@{#405691}
==========

[commit-bot: I haz the power, 2016-07-15 03:57:33]

Patchset 2 (id:??) landed as
https://crrev.com/45582d25b93f796b89b4207e6a3af66d734ed952
Cr-Commit-Position: refs/heads/master@{#405691}