third_party/WebKit/Source/core/dom/RangeBoundaryPoint.h - Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/RangeBoundaryPoint.h

Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/dom/RangeBoundaryPoint.h

diff --git a/third_party/WebKit/Source/core/dom/RangeBoundaryPoint.h b/third_party/WebKit/Source/core/dom/RangeBoundaryPoint.h

index 7816917472ca3e7ee40f95fe443d98d37f4cafac..fcea1032ccc2eda622c7f5ad03097568520bd894 100644

--- a/third_party/WebKit/Source/core/dom/RangeBoundaryPoint.h

+++ b/third_party/WebKit/Source/core/dom/RangeBoundaryPoint.h

@@ -39,7 +39,7 @@ public:

explicit RangeBoundaryPoint(const RangeBoundaryPoint&);

- bool inShadowIncludingDocument() const;

+ bool isConnected() const;

const Position toPosition() const;

Node* container() const;

@@ -122,9 +122,9 @@ inline void RangeBoundaryPoint::ensureOffsetIsValid() const

m_offsetInContainer = m_childBeforeBoundary->nodeIndex() + 1;

}

-inline bool RangeBoundaryPoint::inShadowIncludingDocument() const

+inline bool RangeBoundaryPoint::isConnected() const

{

- return m_containerNode && m_containerNode->inShadowIncludingDocument();

+ return m_containerNode && m_containerNode->isConnected();

}

inline bool RangeBoundaryPoint::isOffsetValid() const

« no previous file with comments | « third_party/WebKit/Source/core/dom/Range.cpp ('k') | third_party/WebKit/Source/core/dom/ScriptLoader.cpp » ('j') | no next file with comments »