Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Unified Diff: third_party/WebKit/Source/core/dom/Fullscreen.cpp

Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Fullscreen.cpp
diff --git a/third_party/WebKit/Source/core/dom/Fullscreen.cpp b/third_party/WebKit/Source/core/dom/Fullscreen.cpp
index 0c73478e86575a54db91d9835de4918f346b4416..ebdca0e38d66995b95607ff5c0664a124f3a6636 100644
--- a/third_party/WebKit/Source/core/dom/Fullscreen.cpp
+++ b/third_party/WebKit/Source/core/dom/Fullscreen.cpp
@@ -79,7 +79,7 @@ bool fullscreenElementReady(const Element& element)
// following are true, and false otherwise:
// |element| is in a document.
- if (!element.inShadowIncludingDocument())
+ if (!element.isConnected())
return false;
// |element|'s node document's fullscreen enabled flag is set.
@@ -416,7 +416,7 @@ void Fullscreen::exitFullscreen()
// If doc's fullscreen element stack is non-empty and the element now at the top is either
// not in a document or its node document is not doc, repeat this substep.
newTop = fullscreenElementFrom(*currentDoc);
- if (newTop && (!newTop->inShadowIncludingDocument() || newTop->document() != currentDoc))
+ if (newTop && (!newTop->isConnected() || newTop->document() != currentDoc))
continue;
// 2. Queue a task to fire an event named fullscreenchange with its bubbles attribute set to true
@@ -639,7 +639,7 @@ void Fullscreen::eventQueueTimerFired(Timer<Fullscreen>*)
Node* target = event->target()->toNode();
// If the element was removed from our tree, also message the documentElement.
- if (!target->inShadowIncludingDocument() && document()->documentElement()) {
+ if (!target->isConnected() && document()->documentElement()) {
DCHECK(isPrefixed(event->type()));
eventQueue.append(createEvent(event->type(), *document()->documentElement()));
}
« no previous file with comments | « third_party/WebKit/Source/core/dom/Element.cpp ('k') | third_party/WebKit/Source/core/dom/IntersectionObservation.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698