third_party/WebKit/Source/core/html/HTMLFormElement.cpp - Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLFormElement.cpp

Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLFormControlElementWithState.cpp ('k') | third_party/WebKit/Source/core/html/HTMLFrameElementBase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLFormElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLFormElement.cpp b/third_party/WebKit/Source/core/html/HTMLFormElement.cpp

index 07d4e00a492a4eb51ae53c3fae40996e08313b82..74f3f106150e0d12189e8154076f81e77a99dc13 100644

--- a/third_party/WebKit/Source/core/html/HTMLFormElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLFormElement.cpp

@@ -138,7 +138,7 @@ Node::InsertionNotificationRequest HTMLFormElement::insertedInto(ContainerNode*

{

HTMLElement::insertedInto(insertionPoint);

logAddElementIfIsolatedWorldAndInDocument("form", methodAttr, actionAttr);

- if (insertionPoint->inShadowIncludingDocument())

+ if (insertionPoint->isConnected())

this->document().didAssociateFormControl(this);

return InsertionDone;

}

@@ -343,7 +343,7 @@ void HTMLFormElement::submit(Event* event, bool activateSubmitButton)

if (!view || !frame || !frame->page())

return;

// See crbug.com/586749.

- if (!inShadowIncludingDocument())

+ if (!isConnected())

UseCounter::count(document(), UseCounter::FormSubmissionNotInDocumentTree);

if (m_isSubmittingOrInUserJSSubmitEvent) {

@@ -558,7 +558,7 @@ const FormAssociatedElement::List& HTMLFormElement::associatedElements() const

Node* scope = mutableThis;

if (m_hasElementsAssociatedByParser)

scope = &NodeTraversal::highestAncestorOrSelf(*mutableThis);

- if (inShadowIncludingDocument() && m_hasElementsAssociatedByFormAttribute)

+ if (isConnected() && m_hasElementsAssociatedByFormAttribute)

scope = &treeScope().rootNode();

ASSERT(scope);

collectAssociatedElements(*scope, mutableThis->m_associatedElements);