third_party/WebKit/Source/core/svg/SVGDocumentExtensions.cpp - Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGDocumentExtensions.cpp

Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/svg/SVGDocumentExtensions.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGDocumentExtensions.cpp b/third_party/WebKit/Source/core/svg/SVGDocumentExtensions.cpp

index b150f6c6504ae0bb3c18126ea3256ce887912da8..2f0263c058bde6b245843ccd58fd6b9ccf059c4c 100644

--- a/third_party/WebKit/Source/core/svg/SVGDocumentExtensions.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGDocumentExtensions.cpp

@@ -157,7 +157,7 @@ void SVGDocumentExtensions::reportError(const String& message)

void SVGDocumentExtensions::addPendingResource(const AtomicString& id, Element* element)

{

ASSERT(element);

- ASSERT(element->inShadowIncludingDocument());

+ ASSERT(element->isConnected());

if (id.isEmpty())

return;

« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp ('k') | third_party/WebKit/Source/core/svg/SVGElement.cpp » ('j') | no next file with comments »