third_party/WebKit/Source/core/editing/Position.h - Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/Position.h

Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/PendingSelection.cpp ('k') | third_party/WebKit/Source/core/editing/RelocatablePositionTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/Position.h

diff --git a/third_party/WebKit/Source/core/editing/Position.h b/third_party/WebKit/Source/core/editing/Position.h

index 92fcbc74eb9c5da79f5f68fe7fa3887b70d814cb..189acdb7f51de383f3f86b40a6498772229d5990 100644

--- a/third_party/WebKit/Source/core/editing/Position.h

+++ b/third_party/WebKit/Source/core/editing/Position.h

@@ -137,11 +137,11 @@ public:

Node* anchorNode() const { return m_anchorNode.get(); }

Document* document() const { return m_anchorNode ? &m_anchorNode->document() : 0; }

- bool inShadowIncludingDocument() const { return m_anchorNode && m_anchorNode->inShadowIncludingDocument(); }

+ bool isConnected() const { return m_anchorNode && m_anchorNode->isConnected(); }

bool isNull() const { return !m_anchorNode; }

bool isNotNull() const { return m_anchorNode; }

- bool isOrphan() const { return m_anchorNode && !m_anchorNode->inShadowIncludingDocument(); }

+ bool isOrphan() const { return m_anchorNode && !m_anchorNode->isConnected(); }

// Note: Comparison of positions require both parameters are non-null. You

// should check null-position before comparing them.