Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGLengthTearOff.cpp

Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 || unit == CSSPrimitiveValue::UnitType::Picas; 52 || unit == CSSPrimitiveValue::UnitType::Picas;
53 } 53 }
54 54
55 inline bool isValidLengthUnit(unsigned short type) 55 inline bool isValidLengthUnit(unsigned short type)
56 { 56 {
57 return isValidLengthUnit(static_cast<CSSPrimitiveValue::UnitType>(type)); 57 return isValidLengthUnit(static_cast<CSSPrimitiveValue::UnitType>(type));
58 } 58 }
59 59
60 inline bool canResolveRelativeUnits(const SVGElement* contextElement) 60 inline bool canResolveRelativeUnits(const SVGElement* contextElement)
61 { 61 {
62 return contextElement && contextElement->inShadowIncludingDocument(); 62 return contextElement && contextElement->isConnected();
63 } 63 }
64 64
65 inline CSSPrimitiveValue::UnitType toCSSUnitType(unsigned short type) 65 inline CSSPrimitiveValue::UnitType toCSSUnitType(unsigned short type)
66 { 66 {
67 ASSERT(isValidLengthUnit(type)); 67 ASSERT(isValidLengthUnit(type));
68 if (type == LengthTypeNumber) 68 if (type == LengthTypeNumber)
69 return CSSPrimitiveValue::UnitType::UserUnits; 69 return CSSPrimitiveValue::UnitType::UserUnits;
70 return static_cast<CSSPrimitiveValue::UnitType>(type); 70 return static_cast<CSSPrimitiveValue::UnitType>(type);
71 } 71 }
72 72
(...skipping 162 matching lines...) Expand 10 before | Expand all | Expand 10 after
235 : SVGPropertyTearOff<SVGLength>(target, contextElement, propertyIsAnimVal, a ttributeName) 235 : SVGPropertyTearOff<SVGLength>(target, contextElement, propertyIsAnimVal, a ttributeName)
236 { 236 {
237 } 237 }
238 238
239 DEFINE_TRACE_WRAPPERS(SVGLengthTearOff) 239 DEFINE_TRACE_WRAPPERS(SVGLengthTearOff)
240 { 240 {
241 visitor->traceWrappers(contextElement()); 241 visitor->traceWrappers(contextElement());
242 } 242 }
243 243
244 } // namespace blink 244 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGImageElement.cpp ('k') | third_party/WebKit/Source/core/svg/SVGMPathElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698