third_party/WebKit/Source/core/editing/commands/MoveSelectionCommand.cpp - Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/MoveSelectionCommand.cpp

Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/ReplaceNodeWithSpanCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/MoveSelectionCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/MoveSelectionCommand.cpp b/third_party/WebKit/Source/core/editing/commands/MoveSelectionCommand.cpp

index 221127ce34ec84f9561ce1679cec9917ac4481f3..9255f99b79ede2e9535ae6879c5d1d136ab28bbf 100644

--- a/third_party/WebKit/Source/core/editing/commands/MoveSelectionCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/MoveSelectionCommand.cpp

@@ -63,7 +63,7 @@ void MoveSelectionCommand::doApply(EditingState* editingState)

// set the destination to the ending point after the deletion.

// Fixes: <rdar://problem/3910425> REGRESSION (Mail): Crash in ReplaceSelectionCommand;

// selection is empty, leading to null deref

- if (!pos.inShadowIncludingDocument())

+ if (!pos.isConnected())

pos = endingSelection().start();

cleanupAfterDeletion(editingState, createVisiblePosition(pos));

@@ -71,7 +71,7 @@ void MoveSelectionCommand::doApply(EditingState* editingState)

return;

setEndingSelection(VisibleSelection(pos, endingSelection().affinity(), endingSelection().isDirectional()));

- if (!pos.inShadowIncludingDocument()) {

+ if (!pos.isConnected()) {

// Document was modified out from under us.

return;

}