third_party/WebKit/Source/core/editing/VisibleSelection.cpp - Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/VisibleSelection.cpp

Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/VisiblePosition.cpp ('k') | third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/VisibleSelection.cpp

diff --git a/third_party/WebKit/Source/core/editing/VisibleSelection.cpp b/third_party/WebKit/Source/core/editing/VisibleSelection.cpp

index 5684cc449fb9ffecf989971f39f5394245b9758f..e80e5046aa13b75856a0e93291600facbb0c51f8 100644

--- a/third_party/WebKit/Source/core/editing/VisibleSelection.cpp

+++ b/third_party/WebKit/Source/core/editing/VisibleSelection.cpp

@@ -732,7 +732,7 @@ Element* VisibleSelectionTemplate<Strategy>::rootEditableElement() const

template <typename Strategy>

static bool isValidPosition(const PositionTemplate<Strategy>& position)

{

- if (!position.inShadowIncludingDocument())

+ if (!position.isConnected())

return false;

if (!position.isOffsetInAnchor())

@@ -763,7 +763,7 @@ void VisibleSelectionTemplate<Strategy>::updateIfNeeded()

template <typename Strategy>

void VisibleSelectionTemplate<Strategy>::validatePositionsIfNeeded()

{

- if (!m_base.inShadowIncludingDocument() || !m_extent.inShadowIncludingDocument()) {

+ if (!m_base.isConnected() || !m_extent.isConnected()) {

*this = VisibleSelectionTemplate();

return;

}