third_party/WebKit/Source/core/input/PointerEventManager.cpp - Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/input/PointerEventManager.cpp

Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/input/EventHandler.cpp ('k') | third_party/WebKit/Source/core/page/PointerLockController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/input/PointerEventManager.cpp

diff --git a/third_party/WebKit/Source/core/input/PointerEventManager.cpp b/third_party/WebKit/Source/core/input/PointerEventManager.cpp

index f4f623c6866bb91a80a6d095d5e0aead6082aaa1..c3cb5b770a9521f9937ea289373426c9127a9dcf 100644

--- a/third_party/WebKit/Source/core/input/PointerEventManager.cpp

+++ b/third_party/WebKit/Source/core/input/PointerEventManager.cpp

@@ -43,7 +43,7 @@ const AtomicString& pointerEventNameForTouchPointState(PlatformTouchPoint::Touch

bool isInDocument(EventTarget* n)

{

- return n && n->toNode() && n->toNode()->inShadowIncludingDocument();

+ return n && n->toNode() && n->toNode()->isConnected();

}

WebInputEventResult dispatchMouseEvent(

@@ -673,7 +673,7 @@ bool PointerEventManager::processPendingPointerCapture(

// no longer participating in the tree.

EventTarget* target = pointerCaptureTarget;

if (target->toNode()

- && !target->toNode()->inShadowIncludingDocument()) {

+ && !target->toNode()->isConnected()) {

target = target->toNode()->ownerDocument();

}

dispatchPointerEvent(target,