third_party/WebKit/Source/core/html/HTMLBaseElement.cpp - Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLBaseElement.cpp

Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/FormAssociatedElement.cpp ('k') | third_party/WebKit/Source/core/html/HTMLButtonElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLBaseElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLBaseElement.cpp b/third_party/WebKit/Source/core/html/HTMLBaseElement.cpp

index 3b94b3b343422401b0779ae447cb7c4d12dd63ac..b1009a2059c91eb26f1338f93206cd2689fd9280 100644

--- a/third_party/WebKit/Source/core/html/HTMLBaseElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLBaseElement.cpp

@@ -50,7 +50,7 @@ void HTMLBaseElement::parseAttribute(const QualifiedName& name, const AtomicStri

Node::InsertionNotificationRequest HTMLBaseElement::insertedInto(ContainerNode* insertionPoint)

{

HTMLElement::insertedInto(insertionPoint);

- if (insertionPoint->inShadowIncludingDocument())

+ if (insertionPoint->isConnected())

document().processBaseElement();

return InsertionDone;

}

@@ -58,7 +58,7 @@ Node::InsertionNotificationRequest HTMLBaseElement::insertedInto(ContainerNode*

void HTMLBaseElement::removedFrom(ContainerNode* insertionPoint)

{

HTMLElement::removedFrom(insertionPoint);

- if (insertionPoint->inShadowIncludingDocument())

+ if (insertionPoint->isConnected())

document().processBaseElement();

}