third_party/WebKit/Source/core/html/HTMLTitleElement.cpp - Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLTitleElement.cpp

Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp ('k') | third_party/WebKit/Source/core/html/forms/FormController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLTitleElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLTitleElement.cpp b/third_party/WebKit/Source/core/html/HTMLTitleElement.cpp

index f6c05288d4ced6d4cfb471055d2514522052f919..824c66b410f49e51d6d9d4c4362a63ba0d84c808 100644

--- a/third_party/WebKit/Source/core/html/HTMLTitleElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLTitleElement.cpp

@@ -46,7 +46,7 @@ DEFINE_NODE_FACTORY(HTMLTitleElement)

Node::InsertionNotificationRequest HTMLTitleElement::insertedInto(ContainerNode* insertionPoint)

{

HTMLElement::insertedInto(insertionPoint);

- if (inShadowIncludingDocument() && !isInShadowTree())

+ if (isConnected() && !isInShadowTree())

document().setTitleElement(this);

return InsertionDone;

}

@@ -54,14 +54,14 @@ Node::InsertionNotificationRequest HTMLTitleElement::insertedInto(ContainerNode*

void HTMLTitleElement::removedFrom(ContainerNode* insertionPoint)

{

HTMLElement::removedFrom(insertionPoint);

- if (insertionPoint->inShadowIncludingDocument() && !insertionPoint->isInShadowTree())

+ if (insertionPoint->isConnected() && !insertionPoint->isInShadowTree())

document().removeTitle(this);

}

void HTMLTitleElement::childrenChanged(const ChildrenChange& change)

{

HTMLElement::childrenChanged(change);

- if (inShadowIncludingDocument() && !isInShadowTree() && !m_ignoreTitleUpdatesWhenChildrenChange)

+ if (isConnected() && !isInShadowTree() && !m_ignoreTitleUpdatesWhenChildrenChange)

document().setTitleElement(this);

}