third_party/WebKit/Source/core/dom/Document.cpp - Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/dom/Document.cpp

diff --git a/third_party/WebKit/Source/core/dom/Document.cpp b/third_party/WebKit/Source/core/dom/Document.cpp

index f1cda58caa1a06aa48d220bc7b2ae05dc242d865..6e690585a8aa584e1ef56f584f7ba69df70f4a69 100644

--- a/third_party/WebKit/Source/core/dom/Document.cpp

+++ b/third_party/WebKit/Source/core/dom/Document.cpp

@@ -1833,7 +1833,7 @@ bool Document::needsLayoutTreeUpdateForNode(const Node& node) const

return false;

if (!needsLayoutTreeUpdate())

return false;

- if (!node.inShadowIncludingDocument())

+ if (!node.isConnected())

return false;

if (needsFullLayoutTreeUpdate() || node.needsStyleRecalc() || node.needsStyleInvalidation())

@@ -3448,7 +3448,7 @@ void Document::removeFocusedElementOfSubtree(Node* node, bool amongChildrenOnly)

return;

// We can't be focused if we're not in the document.

- if (!node->inShadowIncludingDocument())

+ if (!node->isConnected())

return;

bool contains = node->isShadowIncludingInclusiveAncestorOf(m_focusedElement.get());

if (contains && (m_focusedElement != node || !amongChildrenOnly))

« no previous file with comments | « third_party/WebKit/Source/core/dom/ContainerNode.cpp ('k') | third_party/WebKit/Source/core/dom/Element.h » ('j') | no next file with comments »