third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp - Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp

Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/shadow/FlatTreeTraversal.cpp ('k') | third_party/WebKit/Source/core/editing/DOMSelection.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp

diff --git a/third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp b/third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp

index 5e7237bc79863efecfebd026872fbfdb7462ca25..3afb29d199955b7c4f528bbe34b0342ac5c502ca 100644

--- a/third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp

+++ b/third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp

@@ -161,7 +161,7 @@ Node::InsertionNotificationRequest ShadowRoot::insertedInto(ContainerNode* inser

{

DocumentFragment::insertedInto(insertionPoint);

- if (!insertionPoint->inShadowIncludingDocument() || !isOldest())

+ if (!insertionPoint->isConnected() || !isOldest())

return InsertionDone;

// FIXME: When parsing <video controls>, insertedInto() is called many times without invoking removedFrom.

@@ -180,7 +180,7 @@ Node::InsertionNotificationRequest ShadowRoot::insertedInto(ContainerNode* inser

void ShadowRoot::removedFrom(ContainerNode* insertionPoint)

{

- if (insertionPoint->inShadowIncludingDocument()) {

+ if (insertionPoint->isConnected()) {

document().styleEngine().shadowRootRemovedFromDocument(this);

if (m_registeredWithParentShadowRoot) {

ShadowRoot* root = host().containingShadowRoot();