Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLScriptElement.cpp

Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserv ed. 5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserv ed.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 logUpdateAttributeIfIsolatedWorldAndInDocument("script", srcAttr, oldVal ue, value); 83 logUpdateAttributeIfIsolatedWorldAndInDocument("script", srcAttr, oldVal ue, value);
84 } else if (name == asyncAttr) { 84 } else if (name == asyncAttr) {
85 m_loader->handleAsyncAttribute(); 85 m_loader->handleAsyncAttribute();
86 } else { 86 } else {
87 HTMLElement::parseAttribute(name, oldValue, value); 87 HTMLElement::parseAttribute(name, oldValue, value);
88 } 88 }
89 } 89 }
90 90
91 Node::InsertionNotificationRequest HTMLScriptElement::insertedInto(ContainerNode * insertionPoint) 91 Node::InsertionNotificationRequest HTMLScriptElement::insertedInto(ContainerNode * insertionPoint)
92 { 92 {
93 if (insertionPoint->inShadowIncludingDocument() && hasSourceAttribute() && ! loader()->isScriptTypeSupported(ScriptLoader::DisallowLegacyTypeInTypeAttribute) ) 93 if (insertionPoint->isConnected() && hasSourceAttribute() && !loader()->isSc riptTypeSupported(ScriptLoader::DisallowLegacyTypeInTypeAttribute))
94 UseCounter::count(document(), UseCounter::ScriptElementWithInvalidTypeHa sSrc); 94 UseCounter::count(document(), UseCounter::ScriptElementWithInvalidTypeHa sSrc);
95 HTMLElement::insertedInto(insertionPoint); 95 HTMLElement::insertedInto(insertionPoint);
96 logAddElementIfIsolatedWorldAndInDocument("script", srcAttr); 96 logAddElementIfIsolatedWorldAndInDocument("script", srcAttr);
97 return InsertionShouldCallDidNotifySubtreeInsertions; 97 return InsertionShouldCallDidNotifySubtreeInsertions;
98 } 98 }
99 99
100 void HTMLScriptElement::didNotifySubtreeInsertionsToDocument() 100 void HTMLScriptElement::didNotifySubtreeInsertionsToDocument()
101 { 101 {
102 m_loader->didNotifySubtreeInsertionsToDocument(); 102 m_loader->didNotifySubtreeInsertionsToDocument();
103 } 103 }
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
179 return new HTMLScriptElement(document(), false, m_loader->alreadyStarted(), false); 179 return new HTMLScriptElement(document(), false, m_loader->alreadyStarted(), false);
180 } 180 }
181 181
182 DEFINE_TRACE(HTMLScriptElement) 182 DEFINE_TRACE(HTMLScriptElement)
183 { 183 {
184 visitor->trace(m_loader); 184 visitor->trace(m_loader);
185 HTMLElement::trace(visitor); 185 HTMLElement::trace(visitor);
186 } 186 }
187 187
188 } // namespace blink 188 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp ('k') | third_party/WebKit/Source/core/html/HTMLSelectElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698