third_party/WebKit/Source/core/html/HTMLShadowElement.cpp - Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLShadowElement.cpp

Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLSelectElement.cpp ('k') | third_party/WebKit/Source/core/html/HTMLStyleElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLShadowElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLShadowElement.cpp b/third_party/WebKit/Source/core/html/HTMLShadowElement.cpp

index 8926204a74c7d9069cbd0741da420723f843d3d7..47bcba6c334c3a638da9e6c0271a8a5b8bf46791 100644

--- a/third_party/WebKit/Source/core/html/HTMLShadowElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLShadowElement.cpp

@@ -68,7 +68,7 @@ ShadowRoot* HTMLShadowElement::olderShadowRoot()

Node::InsertionNotificationRequest HTMLShadowElement::insertedInto(ContainerNode* insertionPoint)

{

- if (insertionPoint->inShadowIncludingDocument()) {

+ if (insertionPoint->isConnected()) {

// Warn if trying to reproject between user agent and author shadows.

ShadowRoot* root = containingShadowRoot();

if (root && root->olderShadowRoot() && root->type() != root->olderShadowRoot()->type()) {