third_party/WebKit/Source/core/svg/SVGLengthTearOff.cpp - Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGLengthTearOff.cpp

Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGImageElement.cpp ('k') | third_party/WebKit/Source/core/svg/SVGMPathElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/SVGLengthTearOff.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGLengthTearOff.cpp b/third_party/WebKit/Source/core/svg/SVGLengthTearOff.cpp

index ebff1f65177f326445c48f10344a3d3bf6ab2c7d..c931f6326b19b83a88d7fbee8b9e74b64bd6ab71 100644

--- a/third_party/WebKit/Source/core/svg/SVGLengthTearOff.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGLengthTearOff.cpp

@@ -59,7 +59,7 @@ inline bool isValidLengthUnit(unsigned short type)

inline bool canResolveRelativeUnits(const SVGElement* contextElement)

{

- return contextElement && contextElement->inShadowIncludingDocument();

+ return contextElement && contextElement->isConnected();

}

inline CSSPrimitiveValue::UnitType toCSSUnitType(unsigned short type)

« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGImageElement.cpp ('k') | third_party/WebKit/Source/core/svg/SVGMPathElement.cpp » ('j') | no next file with comments »