Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp
diff --git a/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp b/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp
index d9dc694304fe25381e6ffb0da5d7c8735c2cfd3c..8a12f1e3019bf3f1dbc5a96bfa9ca025ee641d00 100644
--- a/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp
+++ b/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp
@@ -175,7 +175,7 @@ void InsertListCommand::doApply(EditingState* editingState)
// infinite loop and because there is no more work to be done.
// FIXME(<rdar://problem/5983974>): The endingSelection() may be incorrect here. Compute
// the new location of endOfSelection and use it as the end of the new selection.
- if (!startOfLastParagraph.deepEquivalent().inShadowIncludingDocument())
+ if (!startOfLastParagraph.deepEquivalent().isConnected())
return;
setEndingSelection(startOfCurrentParagraph);
@@ -293,7 +293,7 @@ bool InsertListCommand::doApplyForSingleParagraph(bool forceCreateList, const HT
// Manually remove listNode because moveParagraphWithClones sometimes leaves it behind in the document.
// See the bug 33668 and editing/execCommand/insert-list-orphaned-item-with-nested-lists.html.
// FIXME: This might be a bug in moveParagraphWithClones or deleteSelection.
- if (listElement && listElement->inShadowIncludingDocument()) {
+ if (listElement && listElement->isConnected()) {
removeNode(listElement, editingState);
if (editingState->isAborted())
return false;

Powered by Google App Engine
This is Rietveld 408576698