third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp - Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp

Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLFrameElementBase.cpp ('k') | third_party/WebKit/Source/core/html/HTMLFrameSetElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp b/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp

index 2496c66f261334efec6b0f291a0b9107f7e6e9f5..cb4ff20343cfe5f88a144054124af3a42c7be321 100644

--- a/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp

@@ -149,7 +149,7 @@ void HTMLFrameOwnerElement::setContentFrame(Frame& frame)

// Make sure we will not end up with two frames referencing the same owner element.

ASSERT(!m_contentFrame || m_contentFrame->owner() != this);

// Disconnected frames should not be allowed to load.

- ASSERT(inShadowIncludingDocument());

+ ASSERT(isConnected());

m_contentFrame = &frame;

for (ContainerNode* node = this; node; node = node->parentOrShadowHostNode())