Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1370)

Unified Diff: third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp

Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp
diff --git a/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp b/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp
index afd1ca23e790f098fc5e564c162ae5e208e70ade..5c38a5cf8a10f2ea66bfa5ee2806dfe07d5bf175 100644
--- a/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp
+++ b/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp
@@ -828,7 +828,7 @@ XMLDocumentParser::XMLDocumentParser(DocumentFragment* fragment, Element* parent
}
// If the parent element is not in document tree, there may be no xmlns attribute; just default to the parent's namespace.
- if (m_defaultNamespaceURI.isNull() && !parentElement->inShadowIncludingDocument())
+ if (m_defaultNamespaceURI.isNull() && !parentElement->isConnected())
m_defaultNamespaceURI = parentElement->namespaceURI();
}
@@ -1066,7 +1066,7 @@ void XMLDocumentParser::endElementNs()
// The element's parent may have already been removed from document.
// Parsing continues in this case, but scripts aren't executed.
- if (!element->inShadowIncludingDocument()) {
+ if (!element->isConnected()) {
popCurrentNode();
return;
}
« no previous file with comments | « third_party/WebKit/Source/core/xml/XPathPath.cpp ('k') | third_party/WebKit/Source/modules/canvas2d/CanvasStyle.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698