third_party/WebKit/Source/core/xml/XPathNodeSet.cpp - Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/xml/XPathNodeSet.cpp

Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp ('k') | third_party/WebKit/Source/core/xml/XPathPath.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/xml/XPathNodeSet.cpp

diff --git a/third_party/WebKit/Source/core/xml/XPathNodeSet.cpp b/third_party/WebKit/Source/core/xml/XPathNodeSet.cpp

index 49cbb0f8d75510f0dddfd8f457e0d0016f89a5ca..5aca8e7516a3d84a3af814e265a75c5da6321d98 100644

--- a/third_party/WebKit/Source/core/xml/XPathNodeSet.cpp

+++ b/third_party/WebKit/Source/core/xml/XPathNodeSet.cpp

@@ -199,7 +199,7 @@ static Node* findRootNode(Node* node)

{

if (node->isAttributeNode())

node = toAttr(node)->ownerElement();

- if (node->inShadowIncludingDocument()) {

+ if (node->isConnected()) {

node = &node->document();

} else {

while (Node* parent = node->parentNode())