Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Unified Diff: third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp

Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp
diff --git a/third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp b/third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp
index 3d41d7aaa141a273189fa4dba5332db52612c28f..2d3d2d3c6140763cd1bbebf5a2f1ebfc18ec43eb 100644
--- a/third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp
+++ b/third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp
@@ -521,17 +521,17 @@ SMILTime SMILTimeContainer::updateAnimations(SMILTime elapsed, bool seekToTime)
#endif
for (unsigned i = 0; i < animationsToApplySize; ++i) {
- if (animationsToApply[i]->inShadowIncludingDocument() && animationsToApply[i]->isSVGDiscardElement()) {
+ if (animationsToApply[i]->isConnected() && animationsToApply[i]->isSVGDiscardElement()) {
SVGSMILElement* animDiscard = animationsToApply[i];
SVGElement* targetElement = animDiscard->targetElement();
- if (targetElement && targetElement->inShadowIncludingDocument()) {
+ if (targetElement && targetElement->isConnected()) {
targetElement->remove(IGNORE_EXCEPTION);
- ASSERT(!targetElement->inShadowIncludingDocument());
+ ASSERT(!targetElement->isConnected());
}
- if (animDiscard->inShadowIncludingDocument()) {
+ if (animDiscard->isConnected()) {
animDiscard->remove(IGNORE_EXCEPTION);
- ASSERT(!animDiscard->inShadowIncludingDocument());
+ ASSERT(!animDiscard->isConnected());
}
}
}
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGUseElement.cpp ('k') | third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698