Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Unified Diff: third_party/WebKit/Source/core/editing/PendingSelection.cpp

Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/PendingSelection.cpp
diff --git a/third_party/WebKit/Source/core/editing/PendingSelection.cpp b/third_party/WebKit/Source/core/editing/PendingSelection.cpp
index a3a42151e0c1b7afc0a8e0c372280a8143cd6f4c..a0ce47623cc5323286a52253b4aaef3c798ef531 100644
--- a/third_party/WebKit/Source/core/editing/PendingSelection.cpp
+++ b/third_party/WebKit/Source/core/editing/PendingSelection.cpp
@@ -44,13 +44,13 @@ const VisibleSelection& PendingSelection::visibleSelection() const
static bool isSelectionInDocument(const VisibleSelectionInFlatTree& visibleSelection, const Document& document)
{
const PositionInFlatTree& start = visibleSelection.start();
- if (start.isNotNull() && (!start.inShadowIncludingDocument() || start.document() != document))
+ if (start.isNotNull() && (!start.isConnected() || start.document() != document))
return false;
const PositionInFlatTree& end = visibleSelection.end();
- if (end.isNotNull() && (!end.inShadowIncludingDocument() || end.document() != document))
+ if (end.isNotNull() && (!end.isConnected() || end.document() != document))
return false;
const PositionInFlatTree extent = visibleSelection.extent();
- if (extent.isNotNull() && (!extent.inShadowIncludingDocument() || extent.document() != document))
+ if (extent.isNotNull() && (!extent.isConnected() || extent.document() != document))
return false;
return true;
}
« no previous file with comments | « third_party/WebKit/Source/core/editing/FrameSelection.cpp ('k') | third_party/WebKit/Source/core/editing/Position.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698