third_party/WebKit/Source/core/html/HTMLImageElement.cpp - Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLImageElement.cpp

Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp ('k') | third_party/WebKit/Source/core/html/HTMLInputElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLImageElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLImageElement.cpp b/third_party/WebKit/Source/core/html/HTMLImageElement.cpp

index 2647b3b31e9b2ab662d09933010f0ffcc62df91d..d7133398c63ee0461627fcff1520764c7995d79e 100644

--- a/third_party/WebKit/Source/core/html/HTMLImageElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLImageElement.cpp

@@ -96,7 +96,7 @@ HTMLImageElement::HTMLImageElement(Document& document, HTMLFormElement* form, bo

, m_referrerPolicy(ReferrerPolicyDefault)

{

setHasCustomStyleCallbacks();

- if (form && form->inShadowIncludingDocument()) {

+ if (form && form->isConnected()) {

m_form = form;

m_formWasSetByParser = true;

m_form->associate(*this);

@@ -389,7 +389,7 @@ Node::InsertionNotificationRequest HTMLImageElement::insertedInto(ContainerNode*

// If we have been inserted from a layoutObject-less document,

// our loader may have not fetched the image, so do it now.

- if ((insertionPoint->inShadowIncludingDocument() && !imageLoader().image()) || imageWasModified)

+ if ((insertionPoint->isConnected() && !imageLoader().image()) || imageWasModified)

imageLoader().updateFromElement(ImageLoader::UpdateNormal, m_referrerPolicy);

return HTMLElement::insertedInto(insertionPoint);