third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp - Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp

Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/RetainedDOMInfo.cpp ('k') | third_party/WebKit/Source/core/clipboard/DataTransfer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp b/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp

index ebf4175d16b92685dbcd040effcfd4b919dcaaf5..cc853f2d196aef2f3e8e23712675e76e72d05312 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp

@@ -74,7 +74,7 @@ static void addReferencesForNodeWithEventListeners(v8::Isolate* isolate, Node* n

Node* V8GCController::opaqueRootForGC(v8::Isolate*, Node* node)

{

ASSERT(node);

- if (node->inShadowIncludingDocument()) {

+ if (node->isConnected()) {

Document& document = node->document();

if (HTMLImportsController* controller = document.importsController())

return controller->master();