third_party/WebKit/Source/core/svg/SVGSVGElement.cpp - Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGSVGElement.cpp

Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGMPathElement.cpp ('k') | third_party/WebKit/Source/core/svg/SVGTextPathElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/SVGSVGElement.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGSVGElement.cpp b/third_party/WebKit/Source/core/svg/SVGSVGElement.cpp

index 73bddfc0bd4f4625d3947890011c6ed5d1696afd..10ded6d7cdffa2533f11d42e047733da4873ec98 100644

--- a/third_party/WebKit/Source/core/svg/SVGSVGElement.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGSVGElement.cpp

@@ -104,7 +104,7 @@ SVGViewSpec* SVGSVGElement::currentView()

float SVGSVGElement::currentScale() const

{

- if (!inShadowIncludingDocument() || !isOutermostSVGSVGElement())

+ if (!isConnected() || !isOutermostSVGSVGElement())

return 1;

return m_currentScale;

@@ -113,7 +113,7 @@ float SVGSVGElement::currentScale() const

void SVGSVGElement::setCurrentScale(float scale)

{

ASSERT(std::isfinite(scale));

- if (!inShadowIncludingDocument() || !isOutermostSVGSVGElement())

+ if (!isConnected() || !isOutermostSVGSVGElement())

return;

m_currentScale = scale;

@@ -500,7 +500,7 @@ LayoutObject* SVGSVGElement::createLayoutObject(const ComputedStyle&)

Node::InsertionNotificationRequest SVGSVGElement::insertedInto(ContainerNode* rootParent)

{

- if (rootParent->inShadowIncludingDocument()) {

+ if (rootParent->isConnected()) {

UseCounter::count(document(), UseCounter::SVGSVGElementInDocument);

if (rootParent->document().isXMLDocument())

UseCounter::count(document(), UseCounter::SVGSVGElementInXMLDocument);

@@ -520,7 +520,7 @@ Node::InsertionNotificationRequest SVGSVGElement::insertedInto(ContainerNode* ro

void SVGSVGElement::removedFrom(ContainerNode* rootParent)

{

- if (rootParent->inShadowIncludingDocument()) {

+ if (rootParent->isConnected()) {

SVGDocumentExtensions& svgExtensions = document().accessSVGExtensions();

svgExtensions.removeTimeContainer(this);

svgExtensions.removeSVGRootWithRelativeLengthDescendents(this);