third_party/WebKit/Source/core/editing/RelocatablePositionTest.cpp - Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/RelocatablePositionTest.cpp

Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/Position.h ('k') | third_party/WebKit/Source/core/editing/VisiblePosition.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/RelocatablePositionTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/RelocatablePositionTest.cpp b/third_party/WebKit/Source/core/editing/RelocatablePositionTest.cpp

index 11a71b534e44ffe437de9119adb8e80fdc1f5979..186760481a7d50401288d13d8eab20de46a0bfa9 100644

--- a/third_party/WebKit/Source/core/editing/RelocatablePositionTest.cpp

+++ b/third_party/WebKit/Source/core/editing/RelocatablePositionTest.cpp

@@ -25,7 +25,7 @@ TEST_F(RelocatablePositionTest, position)

// anchor node is moved away from the document.

Position expectedPosition(boldface, PositionAnchorType::AfterAnchor);

Position trackedPosition = relocatablePosition.position();

- EXPECT_TRUE(trackedPosition.anchorNode()->inShadowIncludingDocument());

+ EXPECT_TRUE(trackedPosition.anchorNode()->isConnected());

EXPECT_EQ(createVisiblePosition(expectedPosition).deepEquivalent(), createVisiblePosition(trackedPosition).deepEquivalent());

}

« no previous file with comments | « third_party/WebKit/Source/core/editing/Position.h ('k') | third_party/WebKit/Source/core/editing/VisiblePosition.cpp » ('j') | no next file with comments »