third_party/WebKit/Source/core/editing/EphemeralRange.cpp - Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/EphemeralRange.cpp

Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/DOMSelection.cpp ('k') | third_party/WebKit/Source/core/editing/FrameSelection.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/EphemeralRange.cpp

diff --git a/third_party/WebKit/Source/core/editing/EphemeralRange.cpp b/third_party/WebKit/Source/core/editing/EphemeralRange.cpp

index aa36e1d19cf7681eb9f54865a04a13f08648a24c..a1d9ff5e92e73a3e629236f7b19e5c7bb1e73a8c 100644

--- a/third_party/WebKit/Source/core/editing/EphemeralRange.cpp

+++ b/third_party/WebKit/Source/core/editing/EphemeralRange.cpp

@@ -25,8 +25,8 @@ EphemeralRangeTemplate<Strategy>::EphemeralRangeTemplate(const PositionTemplate<

}

DCHECK(m_endPosition.isNotNull());

DCHECK_EQ(m_startPosition.document(), m_endPosition.document());

- DCHECK(m_startPosition.inShadowIncludingDocument());

- DCHECK(m_endPosition.inShadowIncludingDocument());

+ DCHECK(m_startPosition.isConnected());

+ DCHECK(m_endPosition.isConnected());

DCHECK_LE(m_startPosition, m_endPosition);

}

@@ -48,7 +48,7 @@ EphemeralRangeTemplate<Strategy>::EphemeralRangeTemplate(const Range* range)

{

if (!range)

return;

- DCHECK(range->inShadowIncludingDocument());

+ DCHECK(range->isConnected());

m_startPosition = fromPositionInDOMTree<Strategy>(range->startPosition());

m_endPosition = fromPositionInDOMTree<Strategy>(range->endPosition());

#if DCHECK_IS_ON()