third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp - Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp

Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/FilterEffectBuilder.cpp ('k') | third_party/WebKit/Source/core/svg/SVGDocumentExtensions.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp b/third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp

index b40d3d62658addf035aa0ccd3460cb9c3faa07f8..76d626078b885dae5764ff35add2ae70180ed848 100644

--- a/third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp

@@ -226,7 +226,7 @@ static inline void removeCSSPropertyFromTarget(SVGElement* targetElement, CSSPro

static inline void applyCSSPropertyToTargetAndInstances(SVGElement* targetElement, const QualifiedName& attributeName, const String& valueAsString)

{

ASSERT(targetElement);

- if (attributeName == anyQName() || !targetElement->inShadowIncludingDocument() || !targetElement->parentNode())

+ if (attributeName == anyQName() || !targetElement->isConnected() || !targetElement->parentNode())

return;

CSSPropertyID id = cssPropertyID(attributeName.localName());

@@ -245,7 +245,7 @@ static inline void applyCSSPropertyToTargetAndInstances(SVGElement* targetElemen

static inline void removeCSSPropertyFromTargetAndInstances(SVGElement* targetElement, const QualifiedName& attributeName)

{

ASSERT(targetElement);

- if (attributeName == anyQName() || !targetElement->inShadowIncludingDocument() || !targetElement->parentNode())

+ if (attributeName == anyQName() || !targetElement->isConnected() || !targetElement->parentNode())

return;

CSSPropertyID id = cssPropertyID(attributeName.localName());

@@ -270,7 +270,7 @@ static inline void notifyTargetAboutAnimValChange(SVGElement* targetElement, con

static inline void notifyTargetAndInstancesAboutAnimValChange(SVGElement* targetElement, const QualifiedName& attributeName)

{

ASSERT(targetElement);

- if (attributeName == anyQName() || !targetElement->inShadowIncludingDocument() || !targetElement->parentNode())

+ if (attributeName == anyQName() || !targetElement->isConnected() || !targetElement->parentNode())

return;

SVGElement::InstanceUpdateBlocker blocker(targetElement);