third_party/WebKit/Source/core/html/imports/LinkImport.cpp - Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/imports/LinkImport.cpp

Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/forms/FormController.cpp ('k') | third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/imports/LinkImport.cpp

diff --git a/third_party/WebKit/Source/core/html/imports/LinkImport.cpp b/third_party/WebKit/Source/core/html/imports/LinkImport.cpp

index ca8fcb4f0c40e9dea10491779b67252d6dc2afd3..4d2b4c11e5897086b183962cb52a663b38ff4c37 100644

--- a/third_party/WebKit/Source/core/html/imports/LinkImport.cpp

+++ b/third_party/WebKit/Source/core/html/imports/LinkImport.cpp

@@ -56,7 +56,7 @@ LinkImport::~LinkImport()

Document* LinkImport::importedDocument() const

{

- if (!m_child || !m_owner || !m_owner->inShadowIncludingDocument())

+ if (!m_child || !m_owner || !m_owner->isConnected())

return nullptr;

if (m_child->loader()->hasError())

return nullptr;

@@ -97,7 +97,7 @@ void LinkImport::process()

void LinkImport::didFinish()

{

- if (!m_owner || !m_owner->inShadowIncludingDocument())

+ if (!m_owner || !m_owner->isConnected())

return;

m_owner->scheduleEvent();

}