third_party/WebKit/Source/core/editing/commands/ReplaceNodeWithSpanCommand.cpp - Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/ReplaceNodeWithSpanCommand.cpp

Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/MoveSelectionCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/ReplaceNodeWithSpanCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/ReplaceNodeWithSpanCommand.cpp b/third_party/WebKit/Source/core/editing/commands/ReplaceNodeWithSpanCommand.cpp

index 8a945b5b121461bb725b9ee84caef28a8a322670..66e2b6536d2aed6dba86a00329b4e56741a70513 100644

--- a/third_party/WebKit/Source/core/editing/commands/ReplaceNodeWithSpanCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/ReplaceNodeWithSpanCommand.cpp

@@ -50,7 +50,7 @@ ReplaceNodeWithSpanCommand::ReplaceNodeWithSpanCommand(HTMLElement* element)

static void swapInNodePreservingAttributesAndChildren(HTMLElement* newElement, HTMLElement& elementToReplace)

{

- DCHECK(elementToReplace.inShadowIncludingDocument()) << elementToReplace;

+ DCHECK(elementToReplace.isConnected()) << elementToReplace;

ContainerNode* parentNode = elementToReplace.parentNode();

parentNode->insertBefore(newElement, &elementToReplace);

@@ -67,7 +67,7 @@ static void swapInNodePreservingAttributesAndChildren(HTMLElement* newElement, H

void ReplaceNodeWithSpanCommand::doApply(EditingState*)

{

- if (!m_elementToReplace->inShadowIncludingDocument())

+ if (!m_elementToReplace->isConnected())

return;

if (!m_spanElement)

m_spanElement = HTMLSpanElement::create(m_elementToReplace->document());

@@ -76,7 +76,7 @@ void ReplaceNodeWithSpanCommand::doApply(EditingState*)

void ReplaceNodeWithSpanCommand::doUnapply()

{

- if (!m_spanElement->inShadowIncludingDocument())

+ if (!m_spanElement->isConnected())

return;

swapInNodePreservingAttributesAndChildren(m_elementToReplace.get(), *m_spanElement);

}