third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp - Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/MoveSelectionCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp b/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

index c54fdf7eff1599354a0b77e7d769dc3ad9db8597..65499eb9ef60fe2ad99d7dc84340b1c19243934d 100644

--- a/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

@@ -185,7 +185,7 @@ void InsertTextCommand::doApply(EditingState* editingState)

DCHECK(startPosition.computeContainerNode()) << startPosition;

Position positionBeforeStartNode(Position::inParentBeforeNode(*startPosition.computeContainerNode()));

deleteInsignificantText(startPosition, mostForwardCaretPosition(startPosition));

- if (!startPosition.inShadowIncludingDocument())

+ if (!startPosition.isConnected())

startPosition = positionBeforeStartNode;

if (!isVisuallyEquivalentCandidate(startPosition))

startPosition = mostForwardCaretPosition(startPosition);