third_party/WebKit/Source/core/html/HTMLSelectElement.cpp - Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLScriptElement.cpp ('k') | third_party/WebKit/Source/core/html/HTMLShadowElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp b/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

index edfa1c61e7b2bbb641948c0cfd806718ebb33027..e819f54cba84ee3bcd9f6d84e214ff08b4e1cff4 100644

--- a/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

@@ -749,7 +749,7 @@ void HTMLSelectElement::setRecalcListItems()

m_shouldRecalcListItems = true;

setOptionsChangedOnLayoutObject();

- if (!inShadowIncludingDocument()) {

+ if (!isConnected()) {

if (HTMLOptionsCollection* collection = cachedCollection<HTMLOptionsCollection>(SelectOptions))

collection->invalidateCache();

invalidateSelectedItems();

@@ -905,7 +905,7 @@ void HTMLSelectElement::scrollToOption(HTMLOptionElement* option)

void HTMLSelectElement::scrollToOptionTask()

{

HTMLOptionElement* option = m_optionToScrollTo.release();

- if (!option || !inShadowIncludingDocument())

+ if (!option || !isConnected())

return;

// optionRemoved() makes sure m_optionToScrollTo doesn't have an option with

// another owner.