Add Node::isInDocumentTree()

Add Node::isInDocumentTree()

The behavior of Node::isInDocumentTree() is equal to "in a document tree" defined in
DOM Standard: https://dom.spec.whatwg.org/#in-a-document-tree

Committed: https://crrev.com/cd916ed616da2224e2b7c2b362db62b53dabbc5a
Cr-Commit-Position: refs/heads/master@{#405706}

[hayato, 2016-07-14 09:14:16]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 09:14:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hayato, 2016-07-14 09:25:00]

Description was changed from

==========
Add Node::inDocumentTree()

BUG=
==========

to

==========
Add Node::inDocumentTree()

The behavior of Node::inDocumentTree() is equal to "in a document tree" defined
in DOM Standard: https://dom.spec.whatwg.org/#in-a-document-tree

Note that Node has member functions which use "isIn???Tree" naming pattern (e.g.
inInShadowTree()). This naming pattern, "isIn???Tree", looks redundant, so I
will
rename these functions from "isIn???Tree" to "in???Tree" in another CL.
==========

[hayato, 2016-07-14 09:25:13]

Description was changed from

==========
Add Node::inDocumentTree()

The behavior of Node::inDocumentTree() is equal to "in a document tree" defined
in DOM Standard: https://dom.spec.whatwg.org/#in-a-document-tree

Note that Node has member functions which use "isIn???Tree" naming pattern (e.g.
inInShadowTree()). This naming pattern, "isIn???Tree", looks redundant, so I
will
rename these functions from "isIn???Tree" to "in???Tree" in another CL.
==========

to

==========
Add Node::inDocumentTree()

The behavior of Node::inDocumentTree() is equal to "in a document tree" defined
in
DOM Standard: https://dom.spec.whatwg.org/#in-a-document-tree

Note that Node has member functions which use "isIn???Tree" naming pattern (e.g.
inInShadowTree()). This naming pattern, "isIn???Tree", looks redundant, so I
will
rename these functions from "isIn???Tree" to "in???Tree" in another CL.
==========

[hayato, 2016-07-14 09:29:05]

hayato@chromium.org changed reviewers:
+ kochi@chromium.org, tkent@chromium.org

[hayato, 2016-07-14 09:29:06]

PTAL

[commit-bot: I haz the power, 2016-07-14 11:29:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 11:29:25]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[tkent, 2016-07-15 04:22:10]

> This naming pattern, "isIn???Tree", looks redundant,

I don't think so.  "is" prefix makes code close to English.
  if (node->isInShadowTree()) { ... }
->
  'if node is in shadow tree, ...'

[hayato, 2016-07-15 04:38:39]

On 2016/07/15 at 04:22:10, tkent wrote:
> > This naming pattern, "isIn???Tree", looks redundant,
> 
> I don't think so.  "is" prefix makes code close to English.
>   if (node->isInShadowTree()) { ... }
> ->
>   'if node is in shadow tree, ...'

I got it. I do not have a strong opinion. Let me rename Node::inDocumentTree()
to Node::isInDocumentTree() to be consistent with other functions.

[hayato, 2016-07-15 04:44:13]

Description was changed from

==========
Add Node::inDocumentTree()

The behavior of Node::inDocumentTree() is equal to "in a document tree" defined
in
DOM Standard: https://dom.spec.whatwg.org/#in-a-document-tree

Note that Node has member functions which use "isIn???Tree" naming pattern (e.g.
inInShadowTree()). This naming pattern, "isIn???Tree", looks redundant, so I
will
rename these functions from "isIn???Tree" to "in???Tree" in another CL.
==========

to

==========
Add Node::isInDocumentTree()

The behavior of Node::isInDocumentTree() is equal to "in a document tree"
defined in
DOM Standard: https://dom.spec.whatwg.org/#in-a-document-tree
==========

[hayato, 2016-07-15 04:45:19]

inDocumentTree -> isInDocumentTree

[hayato, 2016-07-15 04:45:22]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 04:45:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kochi, 2016-07-15 04:51:22]

LGTM

[hayato, 2016-07-15 04:54:23]

The CQ bit was unchecked by hayato@chromium.org

[hayato, 2016-07-15 04:54:26]

The CQ bit was checked by hayato@chromium.org

[commit-bot: I haz the power, 2016-07-15 04:54:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 06:13:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-15 06:14:55]

Description was changed from

==========
Add Node::isInDocumentTree()

The behavior of Node::isInDocumentTree() is equal to "in a document tree"
defined in
DOM Standard: https://dom.spec.whatwg.org/#in-a-document-tree
==========

to

==========
Add Node::isInDocumentTree()

The behavior of Node::isInDocumentTree() is equal to "in a document tree"
defined in
DOM Standard: https://dom.spec.whatwg.org/#in-a-document-tree

Committed: https://crrev.com/cd916ed616da2224e2b7c2b362db62b53dabbc5a
Cr-Commit-Position: refs/heads/master@{#405706}
==========

[commit-bot: I haz the power, 2016-07-15 06:14:56]

Patchset 2 (id:??) landed as
https://crrev.com/cd916ed616da2224e2b7c2b362db62b53dabbc5a
Cr-Commit-Position: refs/heads/master@{#405706}