Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 2146973004: Add Node::isInDocumentTree() (Closed)

Created:
4 years, 5 months ago by hayato
Modified:
4 years, 5 months ago
Reviewers:
tkent, kochi
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@is-connected
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Node::isInDocumentTree() The behavior of Node::isInDocumentTree() is equal to "in a document tree" defined in DOM Standard: https://dom.spec.whatwg.org/#in-a-document-tree Committed: https://crrev.com/cd916ed616da2224e2b7c2b362db62b53dabbc5a Cr-Commit-Position: refs/heads/master@{#405706}

Patch Set 1 #

Patch Set 2 : inDocumentTree -> isInDocumentTree #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M third_party/WebKit/Source/core/dom/Element.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Node.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTitleElement.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 21 (13 generated)
hayato
PTAL
4 years, 5 months ago (2016-07-14 09:29:06 UTC) #6
tkent
> This naming pattern, "isIn???Tree", looks redundant, I don't think so. "is" prefix makes code ...
4 years, 5 months ago (2016-07-15 04:22:10 UTC) #9
hayato
On 2016/07/15 at 04:22:10, tkent wrote: > > This naming pattern, "isIn???Tree", looks redundant, > ...
4 years, 5 months ago (2016-07-15 04:38:39 UTC) #10
hayato
inDocumentTree -> isInDocumentTree
4 years, 5 months ago (2016-07-15 04:45:19 UTC) #12
kochi
LGTM
4 years, 5 months ago (2016-07-15 04:51:22 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2146973004/20001
4 years, 5 months ago (2016-07-15 04:54:42 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-15 06:13:53 UTC) #19
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 06:14:56 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cd916ed616da2224e2b7c2b362db62b53dabbc5a
Cr-Commit-Position: refs/heads/master@{#405706}

Powered by Google App Engine
This is Rietveld 408576698