third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp - Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/imports/LinkImport.cpp ('k') | third_party/WebKit/Source/core/input/EventHandler.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp b/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

index 7328980eb2701df140b1164bf83d75bfffdfc960..cf0e65825c990ca2829786ed51e93f1237c2ce1d 100644

--- a/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

+++ b/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

@@ -575,7 +575,7 @@ void MediaControlTimelineElement::defaultEventHandler(Event* event)

if (event->isMouseEvent() && toMouseEvent(event)->button() != LeftButton)

return;

- if (!inShadowIncludingDocument() || !document().isActive())

+ if (!isConnected() || !document().isActive())

return;

if (event->type() == EventTypeNames::mousedown) {

@@ -608,7 +608,7 @@ void MediaControlTimelineElement::defaultEventHandler(Event* event)

bool MediaControlTimelineElement::willRespondToMouseClickEvents()

{

- return inShadowIncludingDocument() && document().isActive();

+ return isConnected() && document().isActive();

}

void MediaControlTimelineElement::setPosition(double currentTime)

@@ -655,7 +655,7 @@ void MediaControlVolumeSliderElement::defaultEventHandler(Event* event)

if (event->isMouseEvent() && toMouseEvent(event)->button() != LeftButton)

return;

- if (!inShadowIncludingDocument() || !document().isActive())

+ if (!isConnected() || !document().isActive())

return;

MediaControlInputElement::defaultEventHandler(event);

@@ -676,7 +676,7 @@ void MediaControlVolumeSliderElement::defaultEventHandler(Event* event)

bool MediaControlVolumeSliderElement::willRespondToMouseMoveEvents()

{

- if (!inShadowIncludingDocument() || !document().isActive())

+ if (!isConnected() || !document().isActive())

return false;

return MediaControlInputElement::willRespondToMouseMoveEvents();

@@ -684,7 +684,7 @@ bool MediaControlVolumeSliderElement::willRespondToMouseMoveEvents()

bool MediaControlVolumeSliderElement::willRespondToMouseClickEvents()

{

- if (!inShadowIncludingDocument() || !document().isActive())

+ if (!isConnected() || !document().isActive())

return false;

return MediaControlInputElement::willRespondToMouseClickEvents();