Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: third_party/WebKit/Source/web/TextFinder.cpp

Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/RotationViewportAnchor.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/TextFinder.cpp
diff --git a/third_party/WebKit/Source/web/TextFinder.cpp b/third_party/WebKit/Source/web/TextFinder.cpp
index 916a97a2058cc8660daabdba0ce5d02feb694bec..8ed0892928f022e5bd83388937b815fd1996dfb0 100644
--- a/third_party/WebKit/Source/web/TextFinder.cpp
+++ b/third_party/WebKit/Source/web/TextFinder.cpp
@@ -496,7 +496,7 @@ void TextFinder::updateFindMatchRects()
size_t deadMatches = 0;
for (FindMatch& match : m_findMatchesCache) {
- if (!match.m_range->boundaryPointsValid() || !match.m_range->startContainer()->inShadowIncludingDocument())
+ if (!match.m_range->boundaryPointsValid() || !match.m_range->startContainer()->isConnected())
match.m_rect = FloatRect();
else if (!m_findMatchRectsAreValid)
match.m_rect = findInPageRectFromRange(match.m_range.get());
@@ -586,7 +586,7 @@ int TextFinder::selectFindMatch(unsigned index, WebRect* selectionRect)
ASSERT_WITH_SECURITY_IMPLICATION(index < m_findMatchesCache.size());
Range* range = m_findMatchesCache[index].m_range;
- if (!range->boundaryPointsValid() || !range->startContainer()->inShadowIncludingDocument())
+ if (!range->boundaryPointsValid() || !range->startContainer()->isConnected())
return -1;
// Check if the match is already selected.
« no previous file with comments | « third_party/WebKit/Source/web/RotationViewportAnchor.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698