third_party/WebKit/Source/core/svg/SVGMPathElement.cpp - Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGMPathElement.cpp

Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGLengthTearOff.cpp ('k') | third_party/WebKit/Source/core/svg/SVGSVGElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/SVGMPathElement.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGMPathElement.cpp b/third_party/WebKit/Source/core/svg/SVGMPathElement.cpp

index e570f343fb42957082a33c714f0a03b24600ad9b..eb5f7ba2b59b8ddc62c1852c9b2f4bdec78bf3a5 100644

--- a/third_party/WebKit/Source/core/svg/SVGMPathElement.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGMPathElement.cpp

@@ -48,7 +48,7 @@ SVGMPathElement::~SVGMPathElement()

void SVGMPathElement::buildPendingResource()

{

clearResourceReferences();

- if (!inShadowIncludingDocument())

+ if (!isConnected())

return;

AtomicString id;

@@ -79,7 +79,7 @@ void SVGMPathElement::clearResourceReferences()

Node::InsertionNotificationRequest SVGMPathElement::insertedInto(ContainerNode* rootParent)

{

SVGElement::insertedInto(rootParent);

- if (rootParent->inShadowIncludingDocument())

+ if (rootParent->isConnected())

buildPendingResource();

return InsertionDone;

}

@@ -88,7 +88,7 @@ void SVGMPathElement::removedFrom(ContainerNode* rootParent)

{

SVGElement::removedFrom(rootParent);

notifyParentOfPathChange(rootParent);

- if (rootParent->inShadowIncludingDocument())

+ if (rootParent->isConnected())

clearResourceReferences();

}

« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGLengthTearOff.cpp ('k') | third_party/WebKit/Source/core/svg/SVGSVGElement.cpp » ('j') | no next file with comments »