third_party/WebKit/Source/core/dom/Range.cpp - Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Range.cpp

Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/dom/Range.cpp

diff --git a/third_party/WebKit/Source/core/dom/Range.cpp b/third_party/WebKit/Source/core/dom/Range.cpp

index cd2864e026863d48c728190ef15cb35193d1806b..d1489f442ba9e1a93b31ee4b57d8d46fbf7aa89f 100644

--- a/third_party/WebKit/Source/core/dom/Range.cpp

+++ b/third_party/WebKit/Source/core/dom/Range.cpp

@@ -115,10 +115,10 @@ void Range::dispose()

m_ownerDocument->detachRange(this);

}

-bool Range::inShadowIncludingDocument() const

+bool Range::isConnected() const

{

- DCHECK_EQ(m_start.inShadowIncludingDocument(), m_end.inShadowIncludingDocument());

- return m_start.inShadowIncludingDocument();

+ DCHECK_EQ(m_start.isConnected(), m_end.isConnected());

+ return m_start.isConnected();

}

void Range::setDocument(Document& document)

« no previous file with comments | « third_party/WebKit/Source/core/dom/Range.h ('k') | third_party/WebKit/Source/core/dom/RangeBoundaryPoint.h » ('j') | no next file with comments »