third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp - Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp

Issue 2149893003: Rename Node::inShadowIncludingDocument() to Node::isConnected() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/TreeScopeStyleSheetCollection.cpp ('k') | third_party/WebKit/Source/core/dom/custom/V0CustomElementCallbackInvocation.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp

diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp b/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp

index 72245da7b33fedbfa0c30e88044881ded386ef5e..e0567a9029abf1241defa983378311411da865fd 100644

--- a/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp

+++ b/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp

@@ -106,7 +106,7 @@ void CustomElementDefinition::upgrade(Element* element)

if (!m_observedAttributes.isEmpty())

enqueueAttributeChangedCallbackForAllAttributes(element);

- if (element->inShadowIncludingDocument() && hasConnectedCallback())

+ if (element->isConnected() && hasConnectedCallback())

enqueueConnectedCallback(element);

m_constructionStack.append(element);